Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Filter data dialog entries by dataset state, only display ok state #18313

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Jun 4, 2024

Fixes #18262. This is temporary minimal fix, the long term goal for the next release is to paginate and also enable user specified advanced filtering.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek
Copy link
Member

mvdbeek commented Jun 4, 2024

Is this only used for visualisations? Other selects might be fine with non-terminal datasets

@guerler guerler marked this pull request as ready for review June 5, 2024 05:11
@dannon dannon merged commit 849d93e into galaxyproject:release_24.1 Jun 5, 2024
29 checks passed
@guerler guerler deleted the fix_data_dialog_filter branch June 6, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants